Readme corrections #2

New Issue

2021-10-09T20:13:27-04:00

Kabouik commented

2021-10-09 20:13:27 -04:00

(Migrated from github.com)

Thanks for this nice script! I only used it for Magisk because I use microG and not OpenGapps (though I would need to carefully check their differences, pros and cons), but found two slight issues in the readme:

python3 -m pip -r requirements.txt

should read

python3 -m pip install -r requirements.txt

Also, since the script will later need to be run as root, I believe the requirements.txt should be installed with sudo too. Installing them with the above command (without sudo) was not enough to install Magisk because tqdm (installed as user) could not be found when executing the waydroid_extras.py as root.

Thanks for this nice script! I only used it for Magisk because I use microG and not OpenGapps (though I would need to carefully check their differences, pros and cons), but found two slight issues in the readme: ``` python3 -m pip -r requirements.txt ``` should read ``` python3 -m pip install -r requirements.txt ``` Also, since the script will later need to be run as root, I believe the requirements.txt should be installed with `sudo` too. Installing them with the above command (without `sudo`) was not enough to install Magisk because `tqdm` (installed as user) could not be found when executing the `waydroid_extras.py` as root.

casualsnek commented

2021-10-10 12:26:52 -04:00

(Migrated from github.com)

Thank you, I just updated README.md with changes !

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wbruno/waydroid_script#2