wbruno/waydroid_script
1
0
Fork 0
Code Issues 122 Pull Requests 24 Actions Packages Projects Releases Wiki Activity

add inline dependencies #269

Open
Alistair1231 wants to merge 2 commits from Alistair1231/inline-dependencies into main
pull from: Alistair1231/inline-dependencies
merge into: :main
Conversation 1 Commits 2 Files Changed 1
+10
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
main.py
+10
View File
@@ -1,4 +1,14 @@
#!/usr/bin/env python3 #!/usr/bin/env python3
# /// script
# dependencies = [
# "tqdm",
# "requests",
# "dbus-python",
# "gbinder",
# "PyGObject",
# "InquirerPy"
copilot-pull-request-reviewer[bot] commented 2026-04-06 07:34:04 -04:00 (Migrated from github.com)
Review
Copy Link
Copy Source

The inline # /// script metadata is parsed as TOML (PEP 723 style). In a TOML array, items must be comma-separated; as written, the dependencies = [ block is invalid and tools like uv run --script will fail to parse it. Add commas between the dependency strings (a trailing comma is also fine).

#   "InquirerPy",
The inline `# /// script` metadata is parsed as TOML (PEP 723 style). In a TOML array, items must be comma-separated; as written, the `dependencies = [` block is invalid and tools like `uv run --script` will fail to parse it. Add commas between the dependency strings (a trailing comma is also fine). ```suggestion # "InquirerPy", ```
# ]
# ///
copilot-pull-request-reviewer[bot] commented 2026-04-06 07:34:05 -04:00 (Migrated from github.com)
Review
Copy Link
Copy Source

This introduces a second source of truth for runtime dependencies (inline here and also in requirements.txt). That duplication can drift over time and cause confusing install/runtime mismatches. Consider either generating/deriving one from the other, or documenting which one is authoritative (and when each should be updated).
This introduces a second source of truth for runtime dependencies (inline here and also in `requirements.txt`). That duplication can drift over time and cause confusing install/runtime mismatches. Consider either generating/deriving one from the other, or documenting which one is authoritative (and when each should be updated). ```suggestion ```
from InquirerPy import inquirer from InquirerPy import inquirer
from InquirerPy.base.control import Choice from InquirerPy.base.control import Choice
from InquirerPy.separator import Separator from InquirerPy.separator import Separator