wbruno/waydroid_script
1
0
Fork 0
Code Issues 122 Pull Requests 24 Actions Packages Projects Releases Wiki Activity

Use WayDroid 1.4 features like dbus and overlayfs #64

Merged
ayasa520 merged 41 commits from 1.4 into main 2023-01-23 10:30:34 -05:00
Conversation 13 Commits 41 Files Changed 15
+3 -3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit de2b5597e1 - Show all commits
waydroid_extras.py
+3 -3
View File
@@ -308,10 +308,10 @@ on property:ro.enable.native.bridge.exec=1
def install_houdini(): def install_houdini():
sys_image_mount = "/tmp/waydroidimage" sys_image_mount = "/tmp/waydroidimage"
houdini_zip_url = "https://github.com/natsumerinchan/libhoudini-package/archive/refs/tags/v2.1.zip" houdini_zip_url = "https://www.dropbox.com/s/v7g0fluc7e8tod8/libhoudini.zip?dl=1"
dl_file_name = os.path.join(download_loc, "libhoudini.zip") dl_file_name = os.path.join(download_loc, "libhoudini.zip")
extract_to = "/tmp/houdiniunpack/libhoudini-package-2.1" #All catalog files will be marked as executable! extract_to = "/tmp/houdiniunpack" #All catalog files will be marked as executable!
act_md5 = "25c7532cc4256ee64c12695fc0bc60d0" act_md5 = "838097117cec7762e958d7cbc209415e"
loc_md5 = "" loc_md5 = ""
JamiKettunen commented 2023-01-14 09:17:56 -05:00 (Migrated from github.com)
Review
Copy Link
Copy Source

I should note that it is possible to opt-out of D-Bus service activation entirely in Waydroid 1.4.0, see USE_DBUS_ACTIVATION variable in https://github.com/waydroid/waydroid/blob/main/Makefile; from what I can tell this check would make it impossible to install Magisk on a Waydroid installation with USE_DBUS_ACTIVATION=0 set (since there would be no id.waydro.Container.service)

I should note that it is possible to opt-out of D-Bus service activation entirely in Waydroid 1.4.0, see `USE_DBUS_ACTIVATION` variable in https://github.com/waydroid/waydroid/blob/main/Makefile; from what I can tell this check would make it impossible to install Magisk on a Waydroid installation with `USE_DBUS_ACTIVATION=0` set (since there would be no `id.waydro.Container.service`)
ayasa520 commented 2023-01-14 14:05:21 -05:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Here I think it can be changed to check whether /var/lib/waydroid/rootfs/system/etc/init/bootanim.rc exists

Here I think it can be changed to check whether `/var/lib/waydroid/rootfs/system/etc/init/bootanim.rc` exists
apply_props = { apply_props = {