wbruno/waydroid_script
1
0
Fork 0
Code Issues 122 Pull Requests 24 Actions Packages Projects Releases Wiki Activity

Fixed a bug preventing libhoudini install #14

Closed
DGdev91 wants to merge 1 commits from main into main
pull from: main
merge into: :main
Conversation 4 Commits 1 Files Changed 1
+609 -2148
DGdev91 commented 2021-11-24 18:03:00 -05:00 (Migrated from github.com)
Copy Link
Copy Source

Libhoudini installation is still broken after last commit:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/waydroidimage/system/etc/init/hw/init.rc'

Setting the default value for os.environ.get("ANDROID_VERSION") back to 10 (it's the same for install_ndk method, wich is working fine)

Libhoudini installation is still broken after last commit: _FileNotFoundError: [Errno 2] No such file or directory: '/tmp/waydroidimage/system/etc/init/hw/init.rc'_ Setting the default value for os.environ.get("ANDROID_VERSION") back to 10 (it's the same for install_ndk method, wich is working fine)
casualsnek commented 2021-11-25 01:01:36 -05:00 (Migrated from github.com)
Copy Link
Copy Source

This makes libhoudini installable on Android 10, but breaks on Android 11 images ( also Houdini is mainly intended for a11), you could have used

export ANDROID_VERSION=10
sudo python3 waydroid_script -h

to force install on Android 10 images !

This makes libhoudini installable on Android 10, but breaks on Android 11 images ( also Houdini is mainly intended for a11), you could have used ``` export ANDROID_VERSION=10 sudo python3 waydroid_script -h ``` to force install on Android 10 images !
DGdev91 commented 2021-11-25 07:29:23 -05:00 (Migrated from github.com)
Copy Link
Copy Source

Then, the ndk installation script is broken too (it uses "10" as default).
Anyway, Waydroid's image on github is currently an Android 10 image, would't make more sense to assume "10" by default?

I mean, Magisk and Gapps scripts are mainly for Android 10 too.

....Maybe we should use something else to figure out if the image is Android 10 or 11.
Maybe just checking if "{imagemount}/system/etc/init/hw/init.rc" exists shall do the trick?

Then, the ndk installation script is broken too (it uses "10" as default). Anyway, Waydroid's image on github is currently an Android 10 image, would't make more sense to assume "10" by default? I mean, Magisk and Gapps scripts are mainly for Android 10 too. ....Maybe we should use something else to figure out if the image is Android 10 or 11. Maybe just checking if "{imagemount}/system/etc/init/hw/init.rc" exists shall do the trick?
casualsnek commented 2021-11-25 08:12:26 -05:00 (Migrated from github.com)
Copy Link
Copy Source

Then, the ndk installation script is broken too (it uses "10" as default). Anyway, Waydroid's image on github is currently an Android 10 image, would't make more sense to assume "10" by default?

I mean, Magisk and Gapps scripts are mainly for Android 10 too.

....Maybe we should use something else to figure out if the image is Android 10 or 11. Maybe just checking if "{imagemount}/system/etc/init/hw/init.rc" exists shall do the trick?

Yes, maybe i should check if '/init.rc' exists or not, if it exists modify that else modify 'system/etc/init/hw/init.rc' and just get rid of "ANDROID_VERSION" environment variable !

> Then, the ndk installation script is broken too (it uses "10" as default). Anyway, Waydroid's image on github is currently an Android 10 image, would't make more sense to assume "10" by default? > > I mean, Magisk and Gapps scripts are mainly for Android 10 too. > > ....Maybe we should use something else to figure out if the image is Android 10 or 11. Maybe just checking if "{imagemount}/system/etc/init/hw/init.rc" exists shall do the trick? Yes, maybe i should check if '/init.rc' exists or not, if it exists modify that else modify 'system/etc/init/hw/init.rc' and just get rid of "ANDROID_VERSION" environment variable !
DGdev91 commented 2021-11-26 17:53:28 -05:00 (Migrated from github.com)
Copy Link
Copy Source

Then, the ndk installation script is broken too (it uses "10" as default). Anyway, Waydroid's image on github is currently an Android 10 image, would't make more sense to assume "10" by default?
I mean, Magisk and Gapps scripts are mainly for Android 10 too.
....Maybe we should use something else to figure out if the image is Android 10 or 11. Maybe just checking if "{imagemount}/system/etc/init/hw/init.rc" exists shall do the trick?

Yes, maybe i should check if '/init.rc' exists or not, if it exists modify that else modify 'system/etc/init/hw/init.rc' and just get rid of "ANDROID_VERSION" environment variable !

Ok, done that. Created new pul request https://github.com/casualsnek/waydroid_script/pull/16

Closing this one.

> > Then, the ndk installation script is broken too (it uses "10" as default). Anyway, Waydroid's image on github is currently an Android 10 image, would't make more sense to assume "10" by default? > > I mean, Magisk and Gapps scripts are mainly for Android 10 too. > > ....Maybe we should use something else to figure out if the image is Android 10 or 11. Maybe just checking if "{imagemount}/system/etc/init/hw/init.rc" exists shall do the trick? > > Yes, maybe i should check if '/init.rc' exists or not, if it exists modify that else modify 'system/etc/init/hw/init.rc' and just get rid of "ANDROID_VERSION" environment variable ! Ok, done that. Created new pul request https://github.com/casualsnek/waydroid_script/pull/16 Closing this one.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
wbruno (William L. Bruno)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wbruno/waydroid_script#14