General.install() runs copy() -> extra1() -> set_perm(). set_perm() only walks
self.files, which are paths under copy_dir (the overlay), so the copy that
Magisk.setup() makes into <data_dir>/adb/magisk keeps the 0644 the binaries
inherit from the apk extraction.
A non-executable /data/adb/magisk/magisk64 makes magisk_env() abort at
post-fs-data. Root still works, because that runs from the overlay copy, but
Zygisk never initialises: the Magisk app reports "Zygisk: No" no matter what the
zygisk setting says, and no error is surfaced to explain why. This breaks every
Zygisk module (LSPosed, Shamiko, PlayIntegrityFix, ...).
Fix setup() to apply the same 0755 to its own destination that
Magisk.set_path_perm() already applies to magisk paths.
Adds a regression test that passes with the fix and fails without it. It needs no
Waydroid install, no root and no extra dependencies:
python3 tests/test_magisk_setup_perms.py
Fixes#283
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
MisterWizzardandClaude Opus 5
b09e018894